Be more strict when parsing plists

trufae · radare · commit fc7fa4513014 · 2022-04-26T19:18:26.000+02:00
diff --git a/lib/parse.js b/lib/parse.js
@@ -217,5 +217,7 @@ function parsePlistXML (node) {
 
   } else if (node.nodeName === 'false') {
     return false;
+  } else {
+    throw new Error('Invalid PLIST tag ' + node.nodeName);
   }
 }
diff --git a/test/parse.js b/test/parse.js
@@ -437,6 +437,26 @@ int main(int argc, char *argv[])
       });
     });
 
+    it('should fail parsing invalid xml plist', function () {
+      var xml = multiline(function () {
+/*
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<dict>
+  <key>test</key>
+  <strong>Testing</strong>
+  <key>bar</key>
+  <string></string>
+</dict>
+</plist>
+*/
+      });
+      assert.throws(function () {
+        var parsed = parse(xml);
+      });
+    });
+
     it('should parse an example "Xcode-Info.plist" file', function () {
       var xml = multiline(function () {
 /*

Original file line number	Diff line number	Diff line change
`@@ -217,5 +217,7 @@ function parsePlistXML (node) {`
`217`	`217`
`218`	`218`	`} else if (node.nodeName === 'false') {`
`219`	`219`	`return false;`
	`220`	`+ } else {`
	`221`	`+ throw new Error('Invalid PLIST tag ' + node.nodeName);`
`220`	`222`	`}`
`221`	`223`	`}`