Merge pull request #86 from trufae/fix-null

mreinstein · web-flow · commit 730c3ddfd85c · 2022-04-26T08:45:51.000-07:00
Fix invalid plist build when serializing a null
diff --git a/lib/build.js b/lib/build.js
@@ -133,5 +133,8 @@ function walk_obj(next, next_child) {
     // a typed array
     next_child.ele('data').raw(base64.fromByteArray(new Uint8Array(next.buffer), next_child));
 
+  } else if ('Null' === name) {
+    next_child.ele('null').txt('');
+
   }
 }
diff --git a/test/build.js b/test/build.js
@@ -141,6 +141,19 @@ describe('plist', function () {
 */}));
     });
 
+    it('should not omit null values', function () {
+      var xml = build({ a: null});
+      assert.strictEqual(xml, multiline(function () {/*
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+  <dict>
+    <key>a</key>
+    <null/>
+  </dict>
+</plist>
+*/}));
+    });
   });
 
 });

Original file line number	Diff line number	Diff line change
`@@ -133,5 +133,8 @@ function walk_obj(next, next_child) {`
`133`	`133`	`// a typed array`
`134`	`134`	`next_child.ele('data').raw(base64.fromByteArray(new Uint8Array(next.buffer), next_child));`
`135`	`135`
	`136`	`+ } else if ('Null' === name) {`
	`137`	`+ next_child.ele('null').txt('');`
	`138`	`+`
`136`	`139`	`}`
`137`	`140`	`}`